DataGrid selection refactoring #13848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Dec 7, 2023
|
@maxkatz6 is it possible to backport this to the 11.0 branch? We would like to use the stable branch in our app, thanks! |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
maxkatz6
removed
the
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This is a continuation of #13680 where handled events were ignored in the
DataGridCell. There is similar logic inDataGridRowsthat is quite convoluted and makes no sense to me. It is very old code but there are several code smellsUpdatedStateOnMouseLeftButtonDownsteps in for event bubbling here (instead of eventHandledproperty this uses this property on a DataGrid level)What is the updated/expected behavior with this PR?
The behavior is the same as before. The code is simpler and as with #13680 the motivation is to be able to hook to mouse clicks to update selection logic if needed.
Breaking changes
I don't know about any but if there is any case where the user can click on a row but not on a cell then this is wrong.