Improve DevTools previewer of setter values by including all value priorities #13802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
grokys
approved these changes
May 9, 2024
# Conflicts: # api/Avalonia.nupkg.xml # src/Avalonia.Base/PropertyStore/ValueStore.cs
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Previously only style setters were included in the list, which confused developers when local value overrides their styles.
What is the current behavior?
We have a button with a couple of properties set with local priority:
But old dev tools do not show these values:
What is the updated/expected behavior with this PR?
It's less confusing with this PR:
Note: information about dynamic resources is not preserved with non-setter values. We can't really show it to the developers.
Breaking changes
Old
Avalonia.Diagnostics.AppliedStyletype and related were removed. But I believe this change is justified for 11.1.Fixes #13887