Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking shutdown app with LibInput #13677

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

Seeung
Copy link
Contributor

@Seeung Seeung commented Nov 21, 2023

What does the pull request do?

Fix application crash when using LibInputBackend due to thread not being background

What is the current behavior?

When the application is terminated (for example, calling Shutdown from lifetime), the application does not close

What is the updated/expected behavior with this PR?

The application shuts down

How was the solution implemented (if it's not obvious)?

The IsBackground property for the thread is set

Fixes

Fixes #12334

@Seeung
Copy link
Contributor Author

Seeung commented Nov 21, 2023

@dotnet-policy-service agree

@timunie
Copy link
Contributor

timunie commented Nov 21, 2023

@Seeung please add "Fixes #TheIssueNumer" in your PR description

@Seeung
Copy link
Contributor Author

Seeung commented Nov 21, 2023

@timunie updated

@timunie
Copy link
Contributor

timunie commented Nov 21, 2023

@timunie updated

thx. I added the Fixes keyword. Github needs it to actually close the issue. The PR will be reviewed by someone knowing this OS better than me :-)

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxkatz6 maxkatz6 added this pull request to the merge queue Nov 21, 2023
Merged via the queue into AvaloniaUI:master with commit f8746c2 Nov 21, 2023
6 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Nov 28, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutdown on Linux Framebuffer DRM
3 participants