Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes several dozens of compiler and external analyzer warnings in the desktop solution.
How was the solution implemented?
Apart from the obvious fixes for the most common issues (nullability mismatch, wrong documentation cref, unused event), the notable changes are:
netstandard2.0
. The suppressions don't work correctly for it, and trimming is done on a real TFM anyways. Trim warnings are still enabled as errors fornet6.0
, so nothing should be missed.AsAsyncEnumerable
method to transformIEnumerable
toIAsyncEnumerable
without warnings.Remaining warnings