Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleanup #13656

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Warning cleanup #13656

merged 2 commits into from
Nov 20, 2023

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Nov 19, 2023

What does the pull request do?

This PR fixes several dozens of compiler and external analyzer warnings in the desktop solution.

How was the solution implemented?

Apart from the obvious fixes for the most common issues (nullability mismatch, wrong documentation cref, unused event), the notable changes are:

  • Disabled trim warnings for netstandard2.0. The suppressions don't work correctly for it, and trimming is done on a real TFM anyways. Trim warnings are still enabled as errors for net6.0, so nothing should be missed.
  • Added an AsAsyncEnumerable method to transform IEnumerable to IAsyncEnumerable without warnings.

Remaining warnings

  • Warnings in XAML loader, fixed in Warning fixes kekekeks/XamlX#95 (pending merge).
  • Warnings coming from Avalonia's analyzers itself, will be fixed in another PR for easier review.
  • Warnings in samples, unit tests and mobile projects, will be fixed in another PR.

@jmacato jmacato enabled auto-merge November 20, 2023 07:42
@jmacato jmacato added this pull request to the merge queue Nov 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2023
@jmacato jmacato added this pull request to the merge queue Nov 20, 2023
Merged via the queue into AvaloniaUI:master with commit 9f5a102 Nov 20, 2023
6 checks passed
@MrJul MrJul deleted the fix/warning-cleanup branch November 20, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants