Deferred scrolling #13644
Merged
Deferred scrolling #13644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Nov 17, 2023
|
@TomEdwardsEnscape test |
TomEdwardsEnscape
force-pushed
the
feature/deferred-scrolling
branch
from
c77c9b1 to
b524cc8
Compare
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Implemented deferred scrolling * Set IsDeferredScrollingEnabled in themes, where relevant
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
8 tasks
robloo
added a commit
to robloo/FluentAvalonia
that referenced
this pull request
Apr 13, 2024
Port of upstream AvaloniaUI/Avalonia#13644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deferred scrolling, a feature of WPF. When enabled, dragging a scroll bar thumb won't affect the scrolling content until the pointer is released.
What is the current behavior?
It's not currently possible to prevent users from dragging a scroll thumb up and down the entire scrolled content area very quickly. This is easy to do and can have negative performance implications if a large amount of virtualised content is loaded.
How was the solution implemented (if it's not obvious)?
The solution is unfortunately intrusive, and requires changes to the low-level
Trackcontrol. This is because Avalonia doesn't yet supportBinding.UpdateSourceTrigger. If/when this is added, it will become possible to implement this feature purely withinScrollViewerby not writing binding values back to the source until the user releases the mouse button.However, after discussions with @grokys it has been decided that we can proceed with the intrusive solution.
Breaking changes
None.
Obsoletions / Deprecations
None.