Fix ref assembly generator making nested types public #13513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
force-pushed
the
fix/ref-rewriter-nested-type
branch
from
db8fb39 to
7e50ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes the ref assembly generator incorrectly turning private nested types into public ones.
The access modifiers aren't standard flags: it's an enum that should be accessed through a bitmask.
Cecil already clears the unnecessary bits from the mask when using the boolean setters, so they're used instead of bit fiddling.
Breaking changes
Yes, some nested types were public when they shouldn't.
API diff suppressions have been added.