Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(X11): CS0472 The result of the expression is always 'false' #13510

Merged

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Nov 6, 2023

What does the pull request do?

What is the current behavior?

Because following condition never be true

if (globalFactorString == null && screenFactorsString == null && usePhysicalDpi == null)

GetScalingProvider' always return UserConfiguredScalingProvider`

if (config != null)
provider = new UserConfiguredScalingProvider(config.NamedConfig, config.IndexedConfig);
else if (forceAuto)
provider = new PhysicalDpiScalingProvider();
else
provider = new XrdbScalingProvider(platform);

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@maxkatz6 maxkatz6 added this pull request to the merge queue Nov 7, 2023
Merged via the queue into AvaloniaUI:master with commit acd626b Nov 7, 2023
6 checks passed
@workgroupengineering workgroupengineering deleted the fixes/Plattforms/X11-CS0472 branch November 7, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants