Update HarfBuzzSharp #13357
Merged
Update HarfBuzzSharp #13357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Oct 24, 2023
build/HarfBuzzSharp.props
Outdated
Comment on lines
4
to
10
| <PackageReference Condition="'$(IncludeWindowsSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.Win32" Version="7.3.0" /> | ||
| <PackageReference Condition="'$(IncludeLinuxSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.Linux" Version="7.3.0" /> | ||
| <PackageReference Condition="'$(IncludeMacSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.macOS" Version="7.3.0" /> | ||
| <PackageReference Condition="'$(IncludeWasmSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.WebAssembly" Version="7.3.0" /> | ||
| <PackageReference Condition="'$(IncludeAndroidSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.Android" Version="7.3.0" /> | ||
| <PackageReference Condition="'$(IncludeIOSSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.iOS" Version="7.3.0" /> | ||
| <PackageReference Condition="'$(IncludeTizenSkia)' == 'true'" Include="HarfBuzzSharp.NativeAssets.Tizen" Version="7.3.0" /> |
There was a problem hiding this comment.
Everything but WASM and Linux should still be included automatically. You can see from dependencies page here: https://www.nuget.org/packages/HarfBuzzSharp
.NETStandard 2.0 has Win32 and macOS
And .NET 6 has mobile platforms as well.
There was a problem hiding this comment.
Hmm so it looks like everything is referenced automatically
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, everything automatically, except linux and non-blazor browser. But we already cover these platforms manually.
maxkatz6
reviewed
Oct 24, 2023
| @@ -6,6 +6,7 @@ | |||
| <MSBuildEnableWorkloadResolver>true</MSBuildEnableWorkloadResolver> | |||
| <DebugType>portable</DebugType> | |||
| <AndroidResgenNamespace>Avalonia.Android.Internal</AndroidResgenNamespace> | |||
| <IncludeAndroidSkia>true</IncludeAndroidSkia> | |||
There was a problem hiding this comment.
I think these properties work only when build/HarfBuzzSharp.props is referenced directly in the project.
Gillibald
force-pushed
the
feature/updateHarfBuzzSharp
branch
from
c4ac3d2 to
3d99158
Compare
maxkatz6
approved these changes
Oct 24, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
New environment variables were introduced for each supported platform to only reference the native assets of the current platform
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues