Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextLayout.OverhandLeading calculation #13287

Merged

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Oct 17, 2023

What does the pull request do?

This PR fixes the OverhangLeading calculation

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes: #13285

@Gillibald Gillibald added this pull request to the merge queue Oct 24, 2023
Merged via the queue into AvaloniaUI:master with commit da3d4ca Oct 24, 2023
5 checks passed
@Gillibald Gillibald deleted the fixes/textBlockWithLeadingOverhang branch October 24, 2023 04:18
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 5, 2023
maxkatz6 pushed a commit that referenced this pull request Dec 5, 2023
* Fix overhand leading calculation

* Fix test on Mac

* Fix tests
#Conflicts:
#	tests/Avalonia.Skia.UnitTests/Media/GlyphRunTests.cs
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextBlock misaligned when text starts with '1'
2 participants