[Mac] Fix keyDown event #13280
Merged
[Mac] Fix keyDown event #13280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacato
approved these changes
Oct 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kekekeks
approved these changes
Oct 18, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
* [Mac] Check for space key when keyDown isn't consumed * [Mac] Make sure no text input event is send when a modifier is pressed * [Mac] Refactor keyDown handling * Move ignoreUserInput * Handle keyDown for doCommandSelector #Conflicts: # native/Avalonia.Native/src/OSX/AvnView.mm
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR makes sure we don't raise a keyDown for the space character when IME is active.
This also makes sure we don't raise a text input event when an input modifier is pressed.
What is the current behavior?
What is the updated/expected behavior with this PR?
Flow
flowchart TD EventArrived[Event arrived] --> IsImeEnabled(TextInputClient exists for the control?)--> |Yes| CheckModifierKey CheckModifierKey(Modifier key pressed?) --> |Yes| HandleAppModifierKey HandleAppModifierKey[Pass event to the app] --> CheckAppHandledModifierKey(App handled the event?) --> |Yes| End CheckAppHandledModifierKey --> |No| HandleImeWithModifierKey[Pass the event to IME] --> End CheckModifierKey --> |No| HandleImeWithoutModifierKey HandleImeWithoutModifierKey[Pass the event IME] --> CheckImeHandledWithoutModifierKey CheckImeHandledWithoutModifierKey(IME handled the event?) --> |Yes| End CheckImeHandledWithoutModifierKey --> |No| PassToAppWithoutModifierKey[Pass the event to the app] --> End IsImeEnabled --> |No| PassEventToAppWithoutIme[Pass the event to the app] --> CheckAppHandledEventWithoutIme CheckAppHandledEventWithoutIme(App handled the event?) --> |Yes| End CheckAppHandledEventWithoutIme --> TriggerSimpleKeyEvent(Map key to char and raise TextInput) --> EndHow was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues