Modernized accessor syntax in several places #13044
Conversation
|
You can test this PR using the following package version. |
| { | ||
| get { return System.IO.Path.Combine(OutputPath, "github_icon.png"); } | ||
| } | ||
| private string BitmapPath => System.IO.Path.Combine(OutputPath, "github_icon.png"); |
There was a problem hiding this comment.
IMO this is a step too far. It's less easy to read. The below would have been enough. Yes, this is dev preference which is why I would change less actually. Other people will have different opinions I'm sure.
private string BitmapPath
{
get => System.IO.Path.Combine(OutputPath, "github_icon.png");
}
|
|
||
| private Control Visual | ||
| private Control Visual => new Panel |
There was a problem hiding this comment.
If there is a code block in a getter you really shouldn't be "modernizing" it IMO. It is entirely developer preference in that case.
|
Hi @robloo I just toned down the changes a little. Specifically, the getters that perform calculations are back to having block bodies. See if you like this updated version better. |
|
You can test this PR using the following package version. |
| get { return System.IO.Path.Combine(OutputPath, "github_icon.png"); } | ||
| get | ||
| { | ||
| return System.IO.Path.Combine(OutputPath, "github_icon.png"); |
There was a problem hiding this comment.
To be clear these one-liners make sense to use get => System.IO.Path.Combine(OutputPath, "github_icon.png");
I was referring to the cases where there are multiple lines of code and the cases where you removed the get accessor entirely.
|
You can test this PR using the following package version. |
What does the pull request do?
Modernizes syntax of single-expression
getters andsetters in several files of:Avalonia.Markup.UnitTestsAvalonia.Markup.Xaml.UnitTestsAvalonia.ReactiveUI.UnitTestsAvalonia.RenderTestsWhat is the updated/expected behavior with this PR?
No behavior change