fix: Xaml Compiler error when code-behind class contains a DllImport method
#12882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
reviewed
Sep 14, 2023
| @@ -484,7 +484,7 @@ MethodDefinition CreateTrampolineMethod(bool hasSystemProviderArg) | |||
|
|
|||
| var foundXamlLoader = false; | |||
| // Find AvaloniaXamlLoader.Load(this) or AvaloniaXamlLoader.Load(sp, this) and replace it with !XamlIlPopulateTrampoline(this) | |||
| foreach (var method in classTypeDefinition.Methods.ToArray()) | |||
| foreach (var method in classTypeDefinition.Methods.Where(m=>!m.IsPInvokeImpl).ToArray()) | |||
There was a problem hiding this comment.
We should just check if method.Body == null. There are other similar cases like abstract methods.
maxkatz6
approved these changes
Sep 14, 2023
if you put SourceGenerators.props in a project with path are like this:"C:\GitHub\Avalonia\sample\mobile\android\ANoteSample\ANoteSample.csproj", the Compiler is not able to found `Avalonia.Generators`
…class contains a DllImport method
auto-merge was automatically disabled
September 15, 2023 07:18
Head branch was pushed to by a user without write access
workgroupengineering
force-pushed
the
fixes/DllImport
branch
from
f645a6d to
2637a9c
Compare
|
@workgroupengineering looking from CI logs, it seems like new project is packaged into a nuget file. Can you make sure it doesn't have IsPackable set (probably with some props file by accident)? |
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
…` method (#12882) * fix: Avalonia.Generators not found if you put SourceGenerators.props in a project with path are like this:"C:\GitHub\Avalonia\sample\mobile\android\ANoteSample\ANoteSample.csproj", the Compiler is not able to found `Avalonia.Generators` * test: Add test #10046 Xaml Compiler error when code-behind class contains a DllImport method * fix: Xaml Compiler error when code-behind class contains a DllImport method * fix: Address Review * fix: ValidateApiDiff has thrown an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Avoid Avalonia error
AVLN0004when xaml code-behind class contains aDllImportmethodWhat is the current behavior?
Throw error
AVLN0004What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
In
XamlCompilerTaskExecutor, skip method body analysis whereIsPInvokeImplistrue.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #10046
Depended from #12881