macOS: Don't clear clipboard in SetText. #12866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The managed part is responsible for clearing the clipboard, and does so. In addition, `SetBytes` doesn't clear the clipboard.
jmacato
approved these changes
Sep 12, 2023
|
You can test this PR using the following package version. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kekekeks
reviewed
Sep 12, 2023
Yep, it seems to - I linked the relevant lines in the description. |
grokys
added
the
backport-candidate-11.0.x
grokys
added a commit
that referenced
this pull request
Oct 2, 2023
The managed part is responsible for clearing the clipboard, and does so. In addition, `SetBytes` doesn't clear the clipboard.
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Removes a call to
Clear()in the unmanaged macOS clipboard code. The macOS managed code is responsible for clearing the clipboard. Clearing it here results in any other data formats that have previously been added bySetBytesbeing cleared.For context:
Clear()was added in a seemingly unrelated commitSetBytesin the same file doesn't call clearFixed issues