Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bitmap transcoding for most supported PixelFormats #12807

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Sep 6, 2023

What does the pull request do?

This PR introduces a new interface (IPixelFormatWriter) for writing pixels of different formats.

The IPixelFormatWriter is then used in the new PixelFormatTranscoder class that allows the transcoding of pixels into a different format.

The previous helper method to transcode a bitmap was replaced by the new component.

New API

void Bitmap.CopyPixels(ILockedFramebuffer buffer, AlphaFormat alphaFormat)

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@Gillibald Gillibald changed the title [WIP] Implement bitmap transcoding for most supported PixelFormats Implement bitmap transcoding for most supported PixelFormats Sep 7, 2023
@Gillibald Gillibald requested a review from kekekeks September 8, 2023 07:31
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039289-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039307-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039329-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039359-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039363-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039381-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Introduce PixelFormatTranscoder
Introduce Bitmap.CopyPixels that transcodes pixel and alpha format
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039387-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald added this pull request to the merge queue Sep 14, 2023
Merged via the queue into AvaloniaUI:master with commit fac9e55 Sep 14, 2023
5 checks passed
@Gillibald Gillibald deleted the transcodePixelWriter branch September 14, 2023 07:59
maxkatz6 pushed a commit that referenced this pull request Feb 8, 2024
Introduce PixelFormatTranscoder
Introduce Bitmap.CopyPixels that transcodes pixel and alpha format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants