Use the focus proxy window in X11 #12751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this changeset, we set the input focus (XSetInputFocus) to an invisible auxiliary window instead of setting it to the main window. The intent is to make it possible to correctly switch the focus between the Avalonia window and an embedded window. Here's how XEmbed specification puts it: > [...] if the mouse pointer is within the embedded window, the outer toolkit doesn't see any key events, even if the logical keyboard focus is [] within the outer toolkits toplevel window. [...] The topmost toolkit is required to keep the X input focus on one of its own windows without any embedded children. Keeping the focus on such a window ensures that key events are always delivered to the outer toolkit and thus can be forwarded easily [...]. Source: https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html In the case of DotNetBrowser, we will directly switch the focus back to the proxy window, when the logical focus passes from the embedded Chromium to the host Avalonia window.
kekekeks
reviewed
Sep 1, 2023
|
You can test this PR using the following package version. |
anna-dolbina
reviewed
Sep 1, 2023
anna-dolbina
reviewed
Sep 1, 2023
Co-authored-by: Anna Dolbina <[email protected]>
|
You can test this PR using the following package version. |
|
@kekekeks a message from |
|
No idea, it's controlled by .NET Foundation bot |
kekekeks
approved these changes
Sep 1, 2023
|
Please, squash changes into a single commit, otherwise LGTM |
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Dec 5, 2023
Use the focus proxy window in X11
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this changeset, we set the input focus (XSetInputFocus) to an invisible auxiliary window instead of setting it to the main window.
The intent is to make it possible to correctly switch the focus between the Avalonia window and an embedded window. Here's how XEmbed specification puts it:
Source: https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html
In the case of DotNetBrowser, we will directly switch the focus back to the proxy window when the logical focus passes from the embedded Chromium to the host Avalonia window.
Checklist