Updated Transition to use direct properties via use of new TransitionBase class #12716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
jmacato
approved these changes
Aug 30, 2023
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Updated Transition to use direct properties via use of new TransitionBase class
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Updates the generic
Transitionclass to use direct properties instead of plain CLR properties.What is the current behavior?
CLR properties were used before, which didn't allow bindings. Bindings are necessary to properly support some features we want to implement. The
Animationclass already uses direct properties similar to the changes this PR makes.What is the updated/expected behavior with this PR?
The properties now are direct properties, which do allow bindings.
How was the solution implemented (if it's not obvious)?
Per @kekekeks advice, created a non-generic
TransitionBaseclass to define the direct properties since they can't be defined on a generic type. UpdatedTransitionto inheritTransitionBase.Checklist
Breaking changes
Everything using
Transitiontypes should continue working as-is. These were just backend property implementation changes.Obsoletions / Deprecations
None
Fixed issues
None