Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TextBlock.TextDecorations not inheriting down to inlines. #12624

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

billhenn
Copy link
Contributor

What does the pull request do?

The PR fixes a bug and updates logic so TextBlock.TextDecorations will apply even when TextBlock.Inlines are used.

What is the current behavior?

TextDecorations, unlike nearly all other text related properties, do not currently inherit down from TextBlock to Inlines. TextDecorations DO currently work if TextBlock.Text is specified though.

What is the updated/expected behavior with this PR?

The updated behavior allows TextDecorations to be inherited down into inlines like other text-related properties.

How was the solution implemented (if it's not obvious)?

Updated Inline.TextDecorations to be an attached inherited property like other TextElement properties (FontSize, FontWeight, etc.). Updated TextBlock to add owner that attached property.

Checklist

Breaking changes

Shouldn't be any.

Obsoletions / Deprecations

None

Fixed issues

None

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038656-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 22, 2023
Merged via the queue into AvaloniaUI:master with commit 412438d Aug 22, 2023
grokys pushed a commit that referenced this pull request Sep 28, 2023
Fix for TextBlock.TextDecorations not inheriting down to inlines.
@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Sep 29, 2023
grokys pushed a commit that referenced this pull request Oct 2, 2023
Fix for TextBlock.TextDecorations not inheriting down to inlines.
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants