Improve AutoCompleteBox performance #12338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, making AutoCompleteBox async is a heavy lifting. Tests are failing --> Revert it for now.
|
Note: This solution works best with a minimal |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Aug 29, 2023
timunie
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Improve AutoCompleteBox performance
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
tries to improve AutoCompleteBox performance
What is the current behavior?
The control gets slow and even worse can block the UI for several seconds if the ItemsSource is huge
What is the updated/expected behavior with this PR?
Filtering feels more performant, UI does not freeze
How was the solution implemented (if it's not obvious)?
1. Made filtering async* Had to revert this. The new implementation still feels more performant than before.2. Made filtering cancelable (in private only for now) and thus an ongoing filter action can be cancelled for a newer filter string
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #11867