Update Rotate3DTransition.cs to fix flickering #12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix flickering after transition has finished. This was originally contained in my previous PR, but was lost.
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Jul 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flickering after transition has finished on Rotate3DTransition. This was originally contained in my previous PR, but the commit was lost.
What does the pull request do?
Fixes the rotate 3d transition by not falling back to previous values, which would render the control being rotated away visible for a very short amount of time.
What is the current behavior?
After the current visual has been rotated away, it will become visible for a very short amount of time, so the control looks like its flickering.
What is the updated/expected behavior with this PR?
No more flickering after rotation should occur.
How was the solution implemented (if it's not obvious)?
FillMode of the animation has been set to forward, so that the visual being rotated away will not fall back to initial values, but instead stays away.