Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary cast from RootAutomationNode. #12222

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

grokys
Copy link
Member

@grokys grokys commented Jul 16, 2023

What does the pull request do?

RootAutomationNode casts its peer to WindowBaseAutomationPeer, meaning that no other type of automation peer can be used as a root peer. This is unnecessarily as IRootProvider exposes the required GetPeerFromPoint method anyway.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037810-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys marked this pull request as ready for review July 17, 2023 08:53
@danwalmsley danwalmsley added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit bd48671 Jul 17, 2023
@danwalmsley danwalmsley deleted the fixes/rootautomationnode-cast branch July 17, 2023 09:27
@grokys grokys added backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants