Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle ClrPropertyInfo in StaticResourceExtension #12047

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Jul 5, 2023

What does the pull request do?

Allow get targetType when targetProperty is ClrPropertyInfo

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

  • Allow DelayedBinding.Add to accept Avalonia.Data.Core.IPropertyInfo instead of System.Reflection.PropertyInfo.
  • In StaticResourceExtension wrap System.Reflection.PropertyInfo into ReflectionClrPropertyInfo
  • In StaticResourceExtension replace System.Reflection.PropertyInfo with Avalonia.Data.Core.IPropertyInfo

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Close #11940

@workgroupengineering workgroupengineering force-pushed the features/Core/StaticResourceExtensions branch from 3266c48 to 90e26e0 Compare July 5, 2023 14:30
@workgroupengineering workgroupengineering force-pushed the features/Core/StaticResourceExtensions branch from 90e26e0 to 96e9df2 Compare July 5, 2023 14:31
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037405-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@workgroupengineering workgroupengineering marked this pull request as ready for review July 6, 2023 07:12
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038004-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into AvaloniaUI:master with commit 23d0f7b Aug 29, 2023
@workgroupengineering workgroupengineering deleted the features/Core/StaticResourceExtensions branch August 29, 2023 10:52
@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Oct 2, 2023
grokys pushed a commit that referenced this pull request Oct 2, 2023
…ticResourceExtensions

feat: Handle ClrPropertyInfo in StaticResourceExtension
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants