Android Single Activity #11854
Merged
Android Single Activity #11854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Jun 21, 2023
|
haven't tested, api-wise looks ok |
|
You can test this PR using the following package version. |
|
Does this change the Android project template? |
Yes, it does. A release will be made soon for the xplat template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This pr removes AvaloniaSplashActivity from the Android project. Initialization is now done in AvaloniaMainActivity.
This is to prevent a crash that occurs when the Android OS kills the app process, but as the last activity on the stack is the MainActivity, which can't be directly instantiated currently.
This also improves intent handling, in cases where we want to launch the app when an event occurs in the os, outside of being launched from the launcher.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
AvaloniaSplashActivityis removed.MainActivityin apps now derives fromAvaloniaMainActivity<App>.Obsoletions / Deprecations
Fixed issues