feat: Also allows using string instead of {x:Type} in ControlTemplate.TargetType

[workgroupengineering]

What does the pull request do?

Allows using string instead of {x:Type} in ControlTemplate.TargetType

What is the current behavior?

Throw Unable to resolve suitable regular or attached property

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #11334

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0035851-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0035854-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

[workgroupengineering]

@billhenn Can you try this PR if it solve your problem?

[billhenn]

@workgroupengineering Yes, I can confirm this PR fixes my issue. Thank you.

[grokys]

I've not had time to review this PR yet, but I suspect that we're hitting ordering issues with the transformers as iirc there should be a transformer which transforms string into Type for relevant properties, but could be that it's getting run too late.

[workgroupengineering]

I've not had time to review this PR yet, but I suspect that we're hitting ordering issues with the transformers as iirc there should be a transformer which transforms string into Type for relevant properties, but could be that it's getting run too late.

If you suggest the area to see, I'll try to check.

[grokys]

@workgroupengineering sorry I'm not really familiar enough with the XAML compiler internals to be able to point you to it, this was just from a vague memory of hitting something similar a while ago. Will probably need input from someone who knows this part of the code a bit better.

[workgroupengineering]

@workgroupengineering sorry I'm not really familiar enough with the XAML compiler internals to be able to point you to it, this was just from a vague memory of hitting something similar a while ago. Will probably need input from someone who knows this part of the code a bit better.

I investigated, ControlTheme following the same path.

Avalonia/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/Transformers/AvaloniaXamlIlControlThemeTransformer.cs

Lines 28 to 33 in 4552278

	if (targetTypeNode.Values[0] is XamlTypeExtensionNode extension)
	targetType = extension.Value.GetClrType();
	else if (targetTypeNode.Values[0] is XamlAstTextNode text)
	targetType = TypeReferenceResolver.ResolveType(context, text.Text, false, text, true).GetClrType();
	else
	throw new XamlParseException("Could not determine TargetType for ControlTheme.", targetTypeNode);

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0038662-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[billhenn]

This PR has been floating out there for a while. Just curious as to the status since it would be nice to have the bug fix in place for standalone ControlTemplate usage.

[maxkatz6]

LGTM
Even though it's probably not the best solution, it does match other transformers and adds a test, so it can be refactored in the future.