-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converter for DataValidationErrors #11282
Converter for DataValidationErrors #11282
Conversation
You can test this PR using the following package version. |
For reference #11234 (comment) |
- the converter can be used to change the way a message is print - we use DisplayErrors to get the converted error messages
9b7b086
to
228e7c9
Compare
You can test this PR using the following package version. |
this approach gets rid of the need to DisplayErrors property
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
@maxkatz6 I tried your changes and I think these are a useful addition. Now I need to write some docs before 11.1 is released. Thx ❤️ |
@maxkatz6 we have a failing test here:
Do you know how to solve it? |
What does the pull request do?
Adds a converter attached property to control how DataValidation messages are shown
What is the current behavior?
No easy way to modiy the displayed messages.
What is the updated/expected behavior with this PR?
Easy to use converter attached
How was the solution implemented (if it's not obvious)?
See new sample page
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues