types: make Buffers into mongodb.Binary in lean result type to match runtime behavior #14967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runtime behavior Fix #14902
hasezoey
approved these changes
Oct 17, 2024
2 tasks
|
This seems to be causing #14974. Any chance it can be rolled back since the new types are a breaking change? |
david-loe
added a commit
to david-loe/abrechnung
that referenced
this pull request
Oct 29, 2024
This was referenced Nov 9, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14902
Summary
#14902 points out correctly that
lean()returns buffers as instances ofmongodb.Binaryat runtime, but our types say buffers are of typeBuffer. This PR changes Mongoose's TypeScript types to match the runtime behavior.Examples