Adds Facebook App ID filter #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipjohn
approved these changes
Dec 30, 2018
GaryJones
requested changes
Jun 7, 2024
| @@ -7,6 +7,9 @@ | |||
| $share_link = $this->get( 'share_link' ); | |||
| $update_time = $this->get( 'update_time' ); | |||
| $share_link_amp = $this->get( 'share_link_amp' ); | |||
|
|
|||
| /* This filter is defined in class-wpcom-liveblog-amp.php */ | |||
| $facebook_app_id = apply_filters( 'liveblog_amp_facebook_share_app_id', false ); | |||
There was a problem hiding this comment.
Considering how this is going to be used, it feels like a default value of '' empty string, would be in keeping the right type at least.
|
Would be good to get this filter documented on how to use it too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LIVEBLOG_AMP_FACEBOOK_SHAREconstant is undefined by the plugin, undocumented, and were it to be used, would be broken due to #584.This change defines a filter
liveblog_amp_facebook_share_app_idwhich enables themes to set the Facebook App ID enabling sharing to Facebook.Fixes #584