If there is only one admin role member, the member cannot be deleted. #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakuyaMatsu
force-pushed
the
fix-deleteDomainRoleMember
branch
from
eb2fb15 to
a8a9a64
Compare
havetisyan
reviewed
Nov 27, 2024
| } | ||
| List<RoleMember> members = adminRole.getRoleMembers(); | ||
| if (members.size() == 1 && members.get(0).getMemberName().equals(memberName)) { | ||
| throw ZMSUtils.forbiddenError("deleteDomainRoleMember: Cannot delete last member of 'admin' role", caller); |
There was a problem hiding this comment.
just a minor comment but please use 4 spaces for the indent to be consistent.
Signed-off-by: takumats <[email protected]>
TakuyaMatsu
force-pushed
the
fix-deleteDomainRoleMember
branch
from
a8a9a64 to
a3896ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the admin role has only one member, deleting the member using the deleteDomainRoleMember API will leave the admin role with no members.
Contribution Checklist: