Store SIA certificate creds in AWS parameter store, use custom json … #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2024 21:08
…ormat Signed-off-by: rajeshal <[email protected]>
Signed-off-by: rajeshal <[email protected]>
havetisyan
requested changes
Oct 24, 2024
libs/go/sia/aws/lambda/lambda.go
Outdated
| @@ -29,6 +29,8 @@ import ( | |||
| "github.com/aws/aws-sdk-go-v2/config" | |||
| "github.com/aws/aws-sdk-go-v2/service/secretsmanager" | |||
| "github.com/aws/aws-sdk-go-v2/service/sts" | |||
| "github.com/aws/aws-sdk-go/aws/session" | |||
There was a problem hiding this comment.
AWS SDK v1 is EOL so please use v2 for the implementation
added 2 commits
October 24, 2024 23:45
Signed-off-by: rajeshal <[email protected]>
Signed-off-by: rajeshal <[email protected]>
havetisyan
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…format
Description
Contribution Checklist:
Attach Screenshots (Optional)