improve UX of dropdown inputs #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
commented
Oct 22, 2024
| {...(this.props.stateReducer !== undefined && { | ||
| stateReducer: (state, changes) => this.props.stateReducer(state, changes) | ||
| })} | ||
| defaultHighlightedIndex={0} |
There was a problem hiding this comment.
first item in dropdown is highlighted by default allowing to select the item by pressing Enter on the keyboard
ArtjomsPorss
commented
Oct 22, 2024
Comment on lines
+354
to
+361
| stateReducer={(state, changes)=>{ | ||
| // keep input changes when user clicks outside input | ||
| if(changes.type && (changes.type === Downshift.stateChangeTypes.mouseUp | ||
| || changes.type === Downshift.stateChangeTypes.blurInput)) { | ||
| changes.inputValue = state.inputValue; | ||
| } | ||
| return changes; | ||
| }} |
There was a problem hiding this comment.
when input is defocused, input contents are not deleted anymore
| @@ -345,16 +346,19 @@ class InputDropdown extends React.Component { | |||
| initialSelectedItem={defaultSelectedItem} | |||
| inputValue={this.props.value} | |||
| itemToString={this.props.itemToString} | |||
| onChange={(selected) => this.props.onChange(selected)} | |||
| onSelect={(selected) => this.props.onChange(selected)} // onSelect seem to trigger more consistently than onChange | |||
There was a problem hiding this comment.
using onSelect instead of onChange because it triggered more consistently during functional tests
| @@ -38,6 +39,7 @@ const Icon = (props) => { | |||
| onClick={props.onClick} | |||
| ref={props.innerRef} | |||
| data-testid='icon' | |||
| data-wdio={dataWdio} | |||
There was a problem hiding this comment.
for use in functional tests
chandrasekhar1996
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves UX of inputs that use a dropdown. This includes:
Changes cover:
Contribution Checklist: