ATHENS-7451 - fix red role review icon conditions #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtjomsPorss
force-pushed
the
role-red-review-icon
branch
from
0ea37d2 to
a5cca7e
Compare
ArtjomsPorss
force-pushed
the
role-red-review-icon
branch
from
a5cca7e to
a2a7adf
Compare
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
force-pushed
the
role-red-review-icon
branch
from
a2a7adf to
112cb7c
Compare
chandrasekhar1996
approved these changes
Aug 14, 2024
abvaidya
approved these changes
Aug 14, 2024
havetisyan
added a commit
that referenced
this pull request
Aug 18, 2024
Signed-off-by: Henry Avetisyan <[email protected]>
havetisyan
added a commit
that referenced
this pull request
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix role review icon to appear red when last review/modified date is before 80% of the smallest expiry/review days from now (set in settings).
Contribution Checklist:
Attach Screenshots (Optional)