display warning for expired and disabled members in Roles and Groups #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtjomsPorss
force-pushed
the
display-warning-for-disabled-members
branch
from
a00e299 to
b7d393e
Compare
chandrasekhar1996
suggested changes
Aug 1, 2024
| @@ -54,6 +57,7 @@ const GroupTDStyled = styled.td` | |||
| const EditDiv = styled.div` | |||
| display: flex; | |||
| column-gap: 10px; | |||
| ${(props) => props.expired ? props.expired : ''} | |||
There was a problem hiding this comment.
one suggestion for readability, it maybe better to set the color and font-style here based on whether expired is true or not instead of passing the css in expired field.
ArtjomsPorss
force-pushed
the
display-warning-for-disabled-members
branch
4 times, most recently
from
dd32c4f to
29e7f41
Compare
ArtjomsPorss
commented
Aug 2, 2024
| @@ -54,6 +57,8 @@ const GroupTDStyled = styled.td` | |||
| const EditDiv = styled.div` | |||
| display: flex; | |||
| column-gap: 10px; | |||
| ${props => props.expired && `color: ${props.color};`} | |||
| ${props => props.expired && `font-style: ${props.fontStyle};`} | |||
There was a problem hiding this comment.
@chandrasekhar1996 is this what you meant it to look like?
chandrasekhar1996
approved these changes
Aug 2, 2024
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
force-pushed
the
display-warning-for-disabled-members
branch
from
29e7f41 to
2c097e1
Compare
chandrasekhar1996
approved these changes
Aug 2, 2024
havetisyan
added a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: Henry Avetisyan <[email protected]>
havetisyan
added a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: Henry Avetisyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes affect Roles and Groups Members screen. Shows a warning icon if a Member is disabled or expired. Tooltip of warning icon shows disability reason.
Contribution Checklist:
Attach Screenshots (Optional)