for id tokens with group scope always use full arns #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the calling is asking for an id token with groups claim that include the groups scope, then we must always use the full arn. Otherwise, if we have a role called writers and a group called writers, then with full arn set to false, we'll get groups claim with the same "writers" value which would be ambiguous and result in wrong authorization calls. Now, with roles scope , we'll get either "writers" or "athenz:role.writers" as the groups claims value and with groups scope we'll get "athenz:group:writers" groups claim - no longer ambiguous.