UI: apply timezone settings #2124
Conversation
Signed-off-by: Yosuke Nakada <[email protected]>
|
I apologize for the large commit. If using redux is not appropriate, I'm thinking of exploring other methods. I would appreciate any comments you may have. |
|
Apologies for the delay. Our team has started looking into it but they haven't completed the review yet. I will check with them this week. Thank you for your patience :) |
ui/src/components/member/Member.js
Outdated
| } | ||
| let review = this.props.item.reviewReminder; | ||
| if (review) { | ||
| review = this.localDate.getLocalDate(review, 'UTC', 'UTC'); | ||
| review = this.localDate.getLocalDate(exp, this.props.timeZone, this.props.timeZone); |
There was a problem hiding this comment.
should be review instead of exp
There was a problem hiding this comment.
@mendi160 Thank you for your confirmation. I've fixed it.
Signed-off-by: Yosuke Nakada <[email protected]>
@mendi160 that's actually correct and is not a different time zone. Both are Pacific Time Zone - however, based on the date, it correctly reports the daylight savings time in effect on that date: |
|
@mendi160 I apologize for the confusion, my explanation was not clear. This PR does not change the display according to each user's timezone. In our environment, we basically operate in JST and our users are also familiar with JST. Therefore, we wanted to convert the timezone displayed in the UI to JST, which led to this change. |
If so, it LGTM |
Background
At present, the time displayed in the UI is set to UTC by default. Consequently, users of the UI are required to individually convert the displayed time to their respective local time zones, which can be rather inconvenient.
Overview
In this pull request, I intend to modify the UI so that the displayed time aligns with the server's TimeZone setting, thereby enhancing user experience.
To achieve this, the React components have been updated to obtain TimeZone settings from Redux. I was uncertain about the most appropriate Redux Store for storing the TimeZone settings and ultimately decided on the
domainsstore. If you believe there is a more suitable location for these settings, kindly share your insights.Additionally, as the TimeZone will be utilized across the majority of pages within the UI, I have incorporated the necessary changes into
_app.js. If there is a more efficient or effective approach to implementing this feature, please do not hesitate to share your suggestions.