-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to polkadot v1.9.0 #1290
Conversation
…k-v1.5 # Conflicts: # Cargo.lock
Completely agree, let's just convert them into issues/future items so we don't forget. |
/bench astar-dev,shibuya-dev,shiden-dev orml_oracle |
/bench astar-dev,shibuya-dev,shiden-dev orml_oracle |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9897807613. |
Benchmarks have been finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just revert the author/repo changes in the vendor toml file.
/// OracleMembership wrapper used by benchmarks | ||
#[cfg(feature = "runtime-benchmarks")] | ||
pub struct OracleMembershipWrapper; | ||
|
||
#[cfg(feature = "runtime-benchmarks")] | ||
impl frame_support::traits::SortedMembers<AccountId> for OracleMembershipWrapper { | ||
fn sorted_members() -> Vec<AccountId> { | ||
OracleMembership::sorted_members() | ||
} | ||
|
||
fn add(account: &AccountId) { | ||
frame_support::assert_ok!(OracleMembership::add_member( | ||
frame_system::RawOrigin::Root.into(), | ||
account.to_owned().into() | ||
)); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be extracted into primitives?
@@ -1,10 +1,10 @@ | |||
[package] | |||
name = "evm-tracing-events" | |||
authors = ["PureStake"] | |||
authors = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just revert the authors & repository changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏 💪
/runtime-upgrade-test shibuya |
Invalid runtime. It should be 'shibuya', 'shiden', or 'astar'. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9906066347. |
/runtime-upgrade-test shiden |
/runtime-upgrade-test astar |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9906099998. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9906101453. |
Minimum allowed line rate is |
Important Changes
XCM
Multi
prefix & new way to build & match junctionspallet_xcm
to latest xcm version - [pallet_xcm] Forgotten migration to XCMv4 + addedtry-state
to thepallet_xcm
paritytech/polkadot-sdk#3228reserve_transfer_assets
to support remote reserves paritytech/polkadot-sdk#1672Runtime
CheckMetadataHash
extension, guide here(still updating the summary..., meanwhile please check the notion page)
TODO
test_async_xcm_contract_call_no_ce
xcm simulator test, ignored for nowconstruct_runtime!
added test to build the default config now)Executive
toframe_system
'sSingleBlockMigration
config (not on this PR, maybe later)