Avoid split in offset parsing

AssemblyScript · Nov 18, 2023 · 66c7ef5 · 66c7ef5
1 parent 7f60f4a
commit 66c7ef5
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/std/assembly/date.ts b/std/assembly/date.ts
@@ -73,10 +73,17 @@ export class Date {
           if (i == timeString.length - 1) {
             throw new RangeError(E_INVALIDDATE);
           }
-          let offsetParts = timeString.substring(i+1).split(":");
-          let offsetHours = i32.parse(offsetParts[0]);
-          let offsetMinutes = offsetParts.length >= 2 ? i32.parse(offsetParts[1]) : 0;
-          offsetMs = (offsetHours * 60 + offsetMinutes) * MILLIS_PER_MINUTE;
+
+          let posColon = timeString.indexOf(":", i + 1);
+          if (~posColon) {
+            let offsetHours = i32.parse(timeString.substring(i + 1, posColon));
+            let offsetMinutes = i32.parse(timeString.substring(posColon + 1));
+            offsetMs = (offsetHours * 60 + offsetMinutes) * MILLIS_PER_MINUTE;
+          } else {
+            let offsetHours = i32.parse(timeString.substring(i + 1));
+            offsetMs = offsetHours * MILLIS_PER_HOUR;
+          }    
+
           if (c == 45) offsetMs = -offsetMs; // negative offset
           timeString = timeString.substring(0, i);
           break;