Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BeepPlugin #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create BeepPlugin #75

wants to merge 2 commits into from

Conversation

Frenchy62620
Copy link

The possibility to mark an event with a beep

To have the possibility to mark an event with a beep
@AndersMalmgren
Copy link
Owner

Hi, I will take a close look at this after work, but my first impression is that it breaka our conventions, we do not let plugins spawn threads on their own, we want to Marshall them from the script engine, the start method returns an Action, this action runs in its own thread.

@Frenchy62620
Copy link
Author

i agree, i have just written the idea, after i let you to implement with your convention the code.. i can modify easely some parts of the code, but some parts are complex....

@AndersMalmgren
Copy link
Owner

Hmm, youre code spawns one thread for each tone played, that could hog the computer totally. My Action tip above spawns one thread. But then yo cant play two tones at the same time

@Frenchy62620
Copy link
Author

i dont understant why i spawn one thread each time? its static class and a static class cant be instancied?? i spawn a thread and the thread is sleeping until another each tone awakes it.
could you explain my error please?

after just one tone , yes its the idea..its just to validate an event (button pressed or other).

@AndersMalmgren
Copy link
Owner

I just had a quick look at work, will look more closely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants