Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade greenwood and GitHub Actions for node 18 #110

Merged
merged 7 commits into from
Apr 15, 2023

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Dec 17, 2022

Related Issue

N / A

Summary of Changes

  1. Upgrade latest Greenwood v0.28.0
  2. Update project for Node 18
  3. Clean up outdated WTR config

TODO

  1. Storybook seems broken w/ Node 18 - Dev server breaks with Node 18.0.0 + node-ip 1.1.5 storybookjs/storybook#18019
  2. Regression with serve command when serving prerender SSR routes post alpha.2 release (note: actual prerendering is fine, server is just not finding the HTML file correctly) - serve command not serving prerendered SSR or static export content ProjectEvergreen/greenwood#1072
    Screen Shot 2023-02-20 at 9 38 07 AM

@thescientist13
Copy link
Contributor Author

For Storybook, this suggestion from this thread helped, at least as an interim solution
https://onlinessolution.blogspot.com/2021/11/error-error0308010cdigital-envelope.html

Maybe time to upgrade to Storybook 7?

@thescientist13 thescientist13 force-pushed the chore/upgrade-greenwood-v0.28.0 branch from 7d0ec9e to 7717803 Compare April 2, 2023 00:10
@thescientist13 thescientist13 marked this pull request as ready for review April 2, 2023 00:10
@thescientist13 thescientist13 force-pushed the chore/upgrade-greenwood-v0.28.0 branch from aba4c34 to dd53e84 Compare April 15, 2023 14:59
@thescientist13 thescientist13 merged commit 52cd9b6 into main Apr 15, 2023
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-v0.28.0 branch April 15, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant