Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create allow-list for filtering down devices to only a subset #686

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

nicjohnson145
Copy link
Contributor

I'm trying to run Scrutiny in Kubernetes. My storage solution involves Longhorn. This means that not all drives are "real" so to speak, some of them are mounted due the fact that a certain pod is present on a host. These pods can move about, which means that disks can come and go.

image

In the above screen shotshot, only sda/sdb/sdc are real physical disks that are plugged into the system, sdd/sde are the result of pods. I would list scrutiny to only bother monitoring the "real" disks, thus an allow list to specify which ones. I cannot use the existing devices keyword, because as pods move around I could get more disks than what I have excluded, it would be an endless game of whack-a-mole to exclude the fake disks.

Thus, PR.

@nicjohnson145
Copy link
Contributor Author

Also if you want to see a full functional test, I built a new test image off my fork and it works in the real world, not just in unit tests
image

@AnalogJ
Copy link
Owner

AnalogJ commented Sep 14, 2024

This is great, thanks for the PR! 🎉

Very clean implementation

@AnalogJ AnalogJ merged commit e0fe17a into AnalogJ:master Sep 20, 2024
3 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants