Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix-6165]: Hide PDFs from forward to external #3017

Merged
merged 6 commits into from
Nov 25, 2024
Merged

[fix-6165]: Hide PDFs from forward to external #3017

merged 6 commits into from
Nov 25, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Nov 12, 2024 •
edited by jira bot
Loading

Ticket: SIG-6165

Signalen

Before opening a pull request, please ensure:

  • Make sure your PR title follows naming conventions: [feat-1234]: name feature
  • Double-check your branch is based on main and targets main
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Committed source code is headed by the correct SPDX license expression

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

@alimpens alimpens marked this pull request as draft November 12, 2024 09:41
@alimpens alimpens marked this pull request as ready for review November 12, 2024 10:37
@alimpens alimpens requested a review from Doilee November 12, 2024 10:37
Doilee
Doilee approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@Doilee Doilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ziet er goed uit 👍

@alimpens alimpens merged commit 185a6fd into main Nov 25, 2024
6 checks passed
@alimpens alimpens deleted the 6165-hide-pdfs-from-forward-to-external branch November 25, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doilee Doilee Doilee approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimpens @Doilee