Subdomain for accessmanagement app #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarne
reviewed
Mar 9, 2023
| @@ -410,7 +410,7 @@ private List<SelectListItem> GetAuthenticationLevels(int defaultAuthLevel) | |||
| } | |||
|
|
|||
| private async Task<List<SelectListItem>> GetAppsList() | |||
| { | |||
| { | |||
| sub_filter 'https://altinncdn.no/toolkits/altinn-app-frontend/3/' $LOCAL_SUB_FILTER; | ||
| proxy_pass http://accessmanagementbff/; | ||
| error_page 502 /502Accessmanagement.html; | ||
| proxy_cookie_domain altinn3local.no local.altinn.cloud; |
There was a problem hiding this comment.
proxy_cookie_domain should not be required here, and I’m not sure about the sub_filter
There was a problem hiding this comment.
I'm not sure about it either. @TheTechArch @tjololo Do you have any comments on this?
There was a problem hiding this comment.
You dont need it. Same with Sub filter also I belive. Test without
There was a problem hiding this comment.
@allinox You can remove the sub_filter and proxy_cookie_domain here and test it out before committing the changes to this branch
…om/Altinn/app-localtest into feature/accessmanagement-subdomain
…eature/accessmanagement-subdomain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation