Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial IAuthenticationContext abstraction #880

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Initial IAuthenticationContext abstraction #880

wants to merge 9 commits into from
+1,093 −333

Conversation

martinothamar
Copy link
Contributor

Description

Initial proposal for #763

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@martinothamar martinothamar added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 4, 2024
@martinothamar martinothamar self-assigned this Nov 4, 2024
@martinothamar martinothamar mentioned this pull request Nov 4, 2024
Closed
@martinothamar martinothamar force-pushed the feat/authn-abstraction branch from 3935f27 to 9a48939 Compare November 8, 2024 09:16
@martinothamar martinothamar changed the title Initial IClientContext abstraction Initial IAuthenticationContext abstraction Nov 8, 2024
@martinothamar martinothamar mentioned this pull request Nov 28, 2024
Merged
5 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
src/Altinn.App.Core/Internal/Auth/IAuthenticationContext.cs
?? throw new InvalidOperationException("Could not get user profile while getting user context");

var lookupPartyTask =
PartyId == userProfile.PartyId ? Task.FromResult((Party?)userProfile.Party) : _lookupParty(PartyId);

Check warning

Code scanning / CodeQL

Cast to same type Warning

This cast is redundant because the expression already has type Party.
src/Altinn.App.Core/Internal/Auth/IAuthenticationContext.cs Fixed Show fixed Hide fixed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.7% Coverage on New Code (required ≥ 65%)
22.67% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinothamar martinothamar

Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinothamar