Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signee List Component #2807

Open
wants to merge 23 commits into
base: feature/signing
Choose a base branch
from
Open

Signee List Component #2807

wants to merge 23 commits into from

Conversation

cammiida
Copy link
Contributor

Description

List of Signees to be used in signing task.

Needs APIs to be updated before it works, so adding Cypress tests later.

Example view with mock data:
image

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
src/layout/SigneeList/SigneeStateTag.tsx
export function SigneeStateTag({ state }: { state: SigneeState }) {
const status = getSigneeStatus(state);

let color: TagProps['color'] = 'neutral';

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

The initial value of color is unused, since it is always overwritten.
@cammiida cammiida added the kind/user-story Used for issues that describes functionality for our users. label Dec 11, 2024
@cammiida cammiida changed the base branch from main to feature/signing December 16, 2024 11:31
@cammiida
WIP
30e28eb
@cammiida
adds zod
e808612
@cammiida
returns null instead of throwing in old rendersummary functions for o…
91a81a1 
…rg and person lookup components
@cammiida
adds start of signee list component
353b0cb
@cammiida
makes app table type generic
674fd97
@cammiida
renders tag in table for signee status
a8f2abc
@cammiida
adds header styling to signee list table
c20aff0
@cammiida
adds todos and some error handling
e295e4f
@cammiida
removes fake prop in schema to trigger parsing error
9799c14
@cammiida
moves signee state tag component to its own file
63421ec
@cammiida
adds language and error message when process task is not a signing task
38ee950
@cammiida
fixes caption helptext display
e2cd8dd
@cammiida
added support for caption, description and helptext and sized table t…
77f94e0 
…o md
@cammiida
adds support for organisation signature
6816d6b
@cammiida
adds lang texts for table header
0c83e81
@cammiida
adds sorting on name column
136c3e2
@cammiida
updates todos and removes unnecessary accessors
3b276ab
@cammiida
right aligns the last column
aec5055
@cammiida
updates TODOs
d315c95
@cammiida
removes not found and unnecessary caption font-size
808a6df
@cammiida
smaller improvement to error handling
cfe07cc
@cammiida
adds custom error message to refine
ac9919d
@cammiida cammiida force-pushed the feature/signee-list branch from ed39969 to ac9919d Compare December 16, 2024 13:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
21.7% Coverage on New Code (required ≥ 45%)
0.0% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/user-story Used for issues that describes functionality for our users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout Component for list of signees
1 participant
@cammiida