Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI Grid Cleanup #2567

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

MUI Grid Cleanup #2567

wants to merge 29 commits into from

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Oct 10, 2024

Description

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida force-pushed the chore/mui-grid-cleanup branch 2 times, most recently from 8018960 to 38497c5 Compare October 11, 2024 12:20
Copy link

sonarcloud bot commented Oct 11, 2024

@cammiida cammiida self-assigned this Oct 14, 2024
@cammiida cammiida added kind/other Pull requests containing chores/repo structure/other changes quality/debt labels Oct 14, 2024
@paal2707
Copy link
Contributor

paal2707 commented Oct 21, 2024

Har du tatt i bruk designsystemet sine tokens her?
https://www.designsystemet.no/grunnleggende/designelementer/storrelser-og-avstander

*Edit: Dette gjøres senere

@cammiida cammiida force-pushed the chore/mui-grid-cleanup branch from 38497c5 to 38e755c Compare November 18, 2024 11:15
@cammiida cammiida force-pushed the chore/mui-grid-cleanup branch from 881d0bd to e44e282 Compare November 22, 2024 09:46
@paal2707 paal2707 self-assigned this Nov 29, 2024
@paal2707 paal2707 marked this pull request as ready for review December 17, 2024 11:04
Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/other Pull requests containing chores/repo structure/other changes quality/debt
Projects
Status: 👷 In Progress
Development

Successfully merging this pull request may close these issues.

2 participants