-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use temporary oauth2 tokens for Google registries #93
Use temporary oauth2 tokens for Google registries #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 53.96% 53.96%
=======================================
Files 1 1
Lines 63 63
=======================================
Hits 34 34
Misses 24 24
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@DennisD2 thanks, we are almost done here! Could you please fix the golangci-lint error? |
Sorry was some days off. Will check the lint issue now. |
All green now :-) |
Thanks for your contribution! |
Pull Request Description
Describe what this PR does / why we need it
For Google registries (*.gcr.io), an OAUTH2 token can be created from a (base64 encoded) service account token.
Define credentials like this:
Does this pull request fix one issue?
Fixes #62
Describe how you did it
Added method for getting the temporary OAUTH2 token from the permanent service account token
Describe how to verify it
Define a google repo (with gcr.io in hostname), with credentials including a permanent service account token as password value, use the string
_oauth2_
as username, and use this as image sync target. The sync will work, and use an on-the-fly created OAUTH2 tokenSpecial notes for reviews