Add info for debugDescription #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add parameters info for debugDescription of DataResponse and DownloadResponse
djnivek
approved these changes
Jan 26, 2019
jshier
requested changes
Mar 6, 2019
Source/Response.swift
Outdated
| @@ -88,6 +88,12 @@ extension DataResponse: CustomStringConvertible, CustomDebugStringConvertible { | |||
| /// result. | |||
| public var debugDescription: String { | |||
| let requestDescription = request.map { "\($0.httpMethod!) \($0)" } ?? "nil" | |||
| let parameters = { () -> String in | |||
There was a problem hiding this comment.
You can greatly compact this code, and the naming should reflect the fact that it's the body parameters:
let body = request?.httpBody.map { String(decoding: $0, as: UTF8.self) } ?? "None"
...
[Request Body]: \(body)There was a problem hiding this comment.
Thank you for your suggestion
| @@ -101,6 +107,7 @@ extension DataResponse: CustomStringConvertible, CustomDebugStringConvertible { | |||
|
|
|||
| return """ | |||
| [Request]: \(requestDescription) | |||
| [Parameters]: \(parameters) | |||
| [Response]: \n\(responseDescription) | |||
| [Data]: \(data?.description ?? "None") | |||
There was a problem hiding this comment.
Since you're adding the "Request Body", you should do the same thing here: generate a String from the response Data and update this field to be [Response Body].
There was a problem hiding this comment.
I have added [Response Body]
Source/Response.swift
Outdated
| @@ -272,6 +279,12 @@ extension DownloadResponse: CustomStringConvertible, CustomDebugStringConvertibl | |||
| /// actions, and the response serialization result. | |||
| public var debugDescription: String { | |||
| let requestDescription = request.map { "\($0.httpMethod!) \($0)" } ?? "nil" | |||
| let parameters = { () -> String in | |||
There was a problem hiding this comment.
Same changes as mentioned earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add parameters info for debugDescription of DataResponse and DownloadResponse