Set appropriate protection levels on NetworkReachabilityManager members #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! This should go out with the 4.7.0 release soon. |
jshier
pushed a commit
that referenced
this pull request
Mar 5, 2018
jshier
added a commit
that referenced
this pull request
Dec 7, 2018
* Drop iOS 8 / macOS 10.10 support and remove all workarounds. (#2254) * Decodable response serialization and major refactor (#2265) * First draft of response serializer refactor and decodable serializers. * Refactor serializer protocols and implementations. * Finish refactors, update inline docs. * Remove download serializer from Data, as it’s default now. * Update whitespace. * Add failure expectation test. * Remove unnecessary assert. * Refactor serializers to use throws instead of Result. * Refactor Lock Usage and Introduce Protector (#2290) * Drop iOS 8 / macOS 10.10 support and remove all workarounds. * First draft of response serializer refactor and decodable serializers. * Refactor serializer protocols and implementations. * Finish refactors, update inline docs. * Remove download serializer from Data, as it’s default now. * Update whitespace. * Add failure expectation test. * Initial versions of Mutex and Protector. * Rename value to unsafeValue. * Add UnfairLock. * Use UnfairLock on supported OSes, hide everything. * Clean whitespace. * Cleanup based on comments. * Remove TODO. * Refactor ServerTrustPolicy (#2344) * Drop iOS 8 / macOS 10.10 support and remove all workarounds. * First draft of response serializer refactor and decodable serializers. * Refactor serializer protocols and implementations. * Finish refactors, update inline docs. * Remove download serializer from Data, as it’s default now. * Update whitespace. * Add failure expectation test. * Initial versions of Mutex and Protector. * Rename value to unsafeValue. * Add UnfairLock. * Use UnfairLock on supported OSes, hide everything. * Clean whitespace. * Initial protocol abstraction and multiple evaluation implementation. * Go back to simpler API, add composite case. * Refactor away from enum. * Remove custom tests. * Move key comparison to AnyHashable. * Update all documenation and naming. * Fixup merge. * Whitespace cleanup. * Brotli Support (#2442) * Drop iOS 8 / macOS 10.10 support and remove all workarounds. * First draft of response serializer refactor and decodable serializers. * Refactor serializer protocols and implementations. * Finish refactors, update inline docs. * Remove download serializer from Data, as it’s default now. * Update whitespace. * Add failure expectation test. * Initial versions of Mutex and Protector. * Rename value to unsafeValue. * Add UnfairLock. * Use UnfairLock on supported OSes, hide everything. * Clean whitespace. * Initial protocol abstraction and multiple evaluation implementation. * Go back to simpler API, add composite case. * Refactor away from enum. * Remove custom tests. * Move key comparison to AnyHashable. * Update all documenation and naming. * Add brotli support to default Accept-Encoding header. * Add tests for encodings, make listing dynamic. * Fixes after bad merges. * Added radar to the README for the URLSessionTaskMetrics issue on watchOS. (#2387) * Update to #2389 (#2443) * Clarify OS versions affected by download resume bug (#2389) * Rephrase a bit. * Set appropriate protection levels on NetworkReachabilityManager members (#2393) * Update Installation guide to current version (#2395) * Update for Swift 4.1 / Xcode 9.3. (#2441) * Update for Swift 4.1 / Xcode 9.3. * Update .travis.yml. * Update Ruby/Travis. * ResultTests: Update and fix typos (#2416) Using String.count instead of String.characters.count Fix typos in some test failure messages Asserting nil and not nil with XCTAssertNil and XCTAssertNotNil * Include explicit xcpretty to fix Travis. * Revert to Ruby 2.4.2 due to Travis stupidity. * Add configurable parameter handling to URLEncoding. (#2431) * Add configurable array parameter handling to URLEncoding. * Add configurable boolean parameter handling to URLEncoding. * Addressing PR feedback for URLEncoding. * Documentation for BoolEncoding and ArrayEncoding options in URLEncoding. * Remove pledgie.com (#2446) * Typo in the example code - one missing ( (#2445) * Minor doc reorganization. (#2453) * Move templates into .github folder, in preparation for more. * Update README to fix links geneated by Jazzy. * extend userInfo-dict of .DidComplete-Notification to contain responseData of DataTasks (#2427) * extend userInfo-dict of .DidComplete-Notification to contain responseData of DataTasks * ResponseBodyInNotification: fix unittests sometimes failing on travis ci * Update for 4.7 release. * Add period. * Decodable response serialization and major refactor (#2265) * First draft of response serializer refactor and decodable serializers. * Refactor serializer protocols and implementations. * Finish refactors, update inline docs. * Remove download serializer from Data, as it’s default now. * Update whitespace. * Add failure expectation test. * Remove unnecessary assert. * Refactor serializers to use throws instead of Result. * Refactor Lock Usage and Introduce Protector (#2290) * Drop iOS 8 / macOS 10.10 support and remove all workarounds. * First draft of response serializer refactor and decodable serializers. * Refactor serializer protocols and implementations. * Finish refactors, update inline docs. * Remove download serializer from Data, as it’s default now. * Update whitespace. * Add failure expectation test. * Initial versions of Mutex and Protector. * Rename value to unsafeValue. * Add UnfairLock. * Use UnfairLock on supported OSes, hide everything. * Clean whitespace. * Cleanup based on comments. * Remove TODO. * Fix for Swift 4. * Update for compactMap. * Fixes from merging. * Update .swift-version. * Alamofire 5 Core Rewrite! (#2521) * Works towards integrating rewrite. * Fix more tests. * Add EventMonitor, work towards completion. * Refactor request creation and lifetime methods, implement retry. * Fix asynchronous state changes and cancellation during async work. * Update how we turn strings into data. * Reimplement multipart form data uploads. * Implement downloads, progress, and enable tests. * Remove some generics, cleanup whitespace. * Remove another generic. * Add URLSession intializer and default configuration. * Update podspec for new requirements, link CFNetwork. * Finalize EventMonitor events, other misc. cleanup. * Refactor response description and timings. * Format headers more readably. * Description cleanup. * Remove Timeline. * Cleanup Request and add descriptions. * Start refactoring notifications. * Refactor notifications, add default event monitor implementation. * Revert find/replace change to CHANGELOG. * Remove experimental code. * Mark some TODO refinements. * Switch to a single mutable thread-safe state, reenable validation tests. * Clean up whitespace. * Mark property public instead of open. * Add Alamofire root enum as a namespace for global functionality. * Cleanup Alamofire global functionality, other cleanup. * Cleanup some TODOs, start adding more docs. * Cleanup authorization headers. * Undo some unwanted changes. * Continue work on documentation. * Update how data is created from string. * Refactor file downloads to always move file. * Update event monitor method for new fileURL. * Make acceptableContentTypes an autoclosure, as request is async. * Enable thread sanitizer for iOS and tvOS testing. * Fix iOS example. * Fix test whose value varies by Swift version. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Alamofire 5: Server Trust Errors (#2608) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Refactor evaluation API, DRY up a little bit. * Update convienience property. * Add comment for public `Error` API. * Async RequestAdapter (#2628) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. * Squashed commit of the following: commit 32573d0 Author: Jon Shier <[email protected]> Date: Sat Nov 24 21:38:03 2018 -0500 Revert CocoaPods version. commit 657b2e5 Author: Jon Shier <[email protected]> Date: Sat Nov 24 21:34:07 2018 -0500 Disable swift_versions for now. commit d0208ad Author: Jon Shier <[email protected]> Date: Sat Nov 24 21:22:04 2018 -0500 Updates for 4.8.0 (#2648) * Prepare for 4.8 update. * Update Jazzy docs. * Update Swift packages. * Add os for Travis. * Move base Swift vesion to 4. * Update Travis to use bundle install, include xcpretty. * Fix watchOS targets, tests. * Add support for swift_versions. * Update CHANGELOG and .ruby-version. * Cache bundler and RVM. * Remove manual bundle install. * Use Ruby 2.4.5. * Remove manual RVM cache. * Remove now flaky resume data tests. * Fix non-deterministic tests. * Reenable pod lib lint step. commit cbe9df6 Author: Stéphane Copin <[email protected]> Date: Sun Nov 25 01:05:44 2018 +0100 Makes rethrows all methods that can be marked as rethrows (#2488) * Makes rethrows all methods that can be marked as rethrows * Undo throwing changes to Response. * Remove throwing changes from map. commit eb7610c Author: Giulio <[email protected]> Date: Sun Nov 25 00:58:13 2018 +0100 Improve cURLRepresentation implementation readability (#2625) * Improve cURLRepresentation variable readability * Further condense header handling. commit 9153800 Author: Wanbok Choi (Wayne) <[email protected]> Date: Sun Nov 25 08:36:02 2018 +0900 Add re-designed Package.swift manifest for swift 4 (#2621) commit ed37179 Author: jaltreuter <[email protected]> Date: Sat Nov 24 15:35:29 2018 -0800 Add optional encoding completion callback queue argument for multipart form upload (#2620) * Add optional encoding completion callback queue argument for multipart form upload * Use queue argument of upload function when calling alternate upload function commit a5cd9e2 Author: Jon Shier <[email protected]> Date: Mon Aug 20 01:16:56 2018 -0400 Fix documentation_url in podspec. commit 15d3312 Author: Aryeh Greenberg <[email protected]> Date: Mon Aug 20 00:57:32 2018 -0400 Should explicitly specify documentation url (#2569) Cocoadocs does not work anymore. To avoid a 404 when a user clicks the documentation url on cocoapods, you need to specify a url. commit 85badad Author: Jon Shier <[email protected]> Date: Tue Jul 31 16:37:42 2018 -0400 Add back note about using SO in general. commit fab3c19 Author: Jon Shier <[email protected]> Date: Mon Jul 30 23:03:43 2018 -0400 Update the README for the new forum. commit 61a780f Author: Jon Shier <[email protected]> Date: Sun Jul 8 22:46:35 2018 -0400 Update Podspec. commit 7286193 Author: Jon Shier <[email protected]> Date: Sun Jul 8 22:45:12 2018 -0400 Fix CHANGELOG link. commit 0e41f50 Author: Jon Shier <[email protected]> Date: Sun Jul 8 22:42:50 2018 -0400 Prepare 4.7.3 Release (#2553) * Updates for 4.7.3 release. * Update CHANGELOG. commit b2bafc1 Author: Jon Shier <[email protected]> Date: Sun Jul 8 21:31:09 2018 -0400 Update for Xcode 10 and Swift 4.2 (#2552) * Update for Xcode 10 and Swift 4.2. * Revert Travis update. commit c563be5 Author: Karim <[email protected]> Date: Sat Jul 7 23:27:48 2018 +0100 Use HTTPS links in the documentation (#2550) * Use HTTPS links in CHANGELOG Update CHANGELOG to use HTTPS links instead of HTTP * Use HTTPS links in CONTRIBUTING Update CONTRIBUTING to use HTTPS links instead of HTTP * Use HTTPS links in README Update README to use HTTPS links instead of HTTP if supported * Use HTTPS links in Usage.md Update Usage.md to use HTTPS links instead of HTTP commit ff16ce9 Author: Xing He <[email protected]> Date: Sun Jun 17 06:06:48 2018 +0800 Fix code sytle in documentation (#2484) commit 5773768 Author: Constantin Lungu <[email protected]> Date: Sun Jun 17 01:06:14 2018 +0300 Fix indentation in Usage.md (#2505) * Squashed commit of the following: commit 32573d0 Author: Jon Shier <[email protected]> Date: Sat Nov 24 21:38:03 2018 -0500 Revert CocoaPods version. commit 657b2e5 Author: Jon Shier <[email protected]> Date: Sat Nov 24 21:34:07 2018 -0500 Disable swift_versions for now. commit d0208ad Author: Jon Shier <[email protected]> Date: Sat Nov 24 21:22:04 2018 -0500 Updates for 4.8.0 (#2648) * Prepare for 4.8 update. * Update Jazzy docs. * Update Swift packages. * Add os for Travis. * Move base Swift vesion to 4. * Update Travis to use bundle install, include xcpretty. * Fix watchOS targets, tests. * Add support for swift_versions. * Update CHANGELOG and .ruby-version. * Cache bundler and RVM. * Remove manual bundle install. * Use Ruby 2.4.5. * Remove manual RVM cache. * Remove now flaky resume data tests. * Fix non-deterministic tests. * Reenable pod lib lint step. commit cbe9df6 Author: Stéphane Copin <[email protected]> Date: Sun Nov 25 01:05:44 2018 +0100 Makes rethrows all methods that can be marked as rethrows (#2488) * Makes rethrows all methods that can be marked as rethrows * Undo throwing changes to Response. * Remove throwing changes from map. commit eb7610c Author: Giulio <[email protected]> Date: Sun Nov 25 00:58:13 2018 +0100 Improve cURLRepresentation implementation readability (#2625) * Improve cURLRepresentation variable readability * Further condense header handling. commit 9153800 Author: Wanbok Choi (Wayne) <[email protected]> Date: Sun Nov 25 08:36:02 2018 +0900 Add re-designed Package.swift manifest for swift 4 (#2621) commit ed37179 Author: jaltreuter <[email protected]> Date: Sat Nov 24 15:35:29 2018 -0800 Add optional encoding completion callback queue argument for multipart form upload (#2620) * Add optional encoding completion callback queue argument for multipart form upload * Use queue argument of upload function when calling alternate upload function commit a5cd9e2 Author: Jon Shier <[email protected]> Date: Mon Aug 20 01:16:56 2018 -0400 Fix documentation_url in podspec. commit 15d3312 Author: Aryeh Greenberg <[email protected]> Date: Mon Aug 20 00:57:32 2018 -0400 Should explicitly specify documentation url (#2569) Cocoadocs does not work anymore. To avoid a 404 when a user clicks the documentation url on cocoapods, you need to specify a url. commit 85badad Author: Jon Shier <[email protected]> Date: Tue Jul 31 16:37:42 2018 -0400 Add back note about using SO in general. commit fab3c19 Author: Jon Shier <[email protected]> Date: Mon Jul 30 23:03:43 2018 -0400 Update the README for the new forum. commit 61a780f Author: Jon Shier <[email protected]> Date: Sun Jul 8 22:46:35 2018 -0400 Update Podspec. commit 7286193 Author: Jon Shier <[email protected]> Date: Sun Jul 8 22:45:12 2018 -0400 Fix CHANGELOG link. commit 0e41f50 Author: Jon Shier <[email protected]> Date: Sun Jul 8 22:42:50 2018 -0400 Prepare 4.7.3 Release (#2553) * Updates for 4.7.3 release. * Update CHANGELOG. commit b2bafc1 Author: Jon Shier <[email protected]> Date: Sun Jul 8 21:31:09 2018 -0400 Update for Xcode 10 and Swift 4.2 (#2552) * Update for Xcode 10 and Swift 4.2. * Revert Travis update. commit c563be5 Author: Karim <[email protected]> Date: Sat Jul 7 23:27:48 2018 +0100 Use HTTPS links in the documentation (#2550) * Use HTTPS links in CHANGELOG Update CHANGELOG to use HTTPS links instead of HTTP * Use HTTPS links in CONTRIBUTING Update CONTRIBUTING to use HTTPS links instead of HTTP * Use HTTPS links in README Update README to use HTTPS links instead of HTTP if supported * Use HTTPS links in Usage.md Update Usage.md to use HTTPS links instead of HTTP commit ff16ce9 Author: Xing He <[email protected]> Date: Sun Jun 17 06:06:48 2018 +0800 Fix code sytle in documentation (#2484) commit 5773768 Author: Constantin Lungu <[email protected]> Date: Sun Jun 17 01:06:14 2018 +0300 Fix indentation in Usage.md (#2505) * Real HTTPHeaders type. (#2629) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. * Add HTTPHeaders type. * Update for review suggestions. * Add HTTPHeaders tests, cleanup whitespace. * Add inline documentation. * Updates for review. * Whitespace cleanup. * Squashed commit of the following: commit 7a73af6 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:39:20 2018 -0500 Async RequestAdapter (#2628) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. commit ccfb96a Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:32:04 2018 -0500 Alamofire 5: Server Trust Errors (#2608) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Refactor evaluation API, DRY up a little bit. * Update convienience property. * Add comment for public `Error` API. * Add add methods to HTTPHeaders, whitespace cleanup. * Call add instead of update. * Encodable Request Parameters (#2637) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. * Add HTTPHeaders type. * Update for review suggestions. * Add HTTPHeaders tests, cleanup whitespace. * Add inline documentation. * Prototype encodable request support. * Formalize ParamterEncoder protocol and initial API. * Whitespace cleanup. * Add URLEncodedFormEncoder. * Sort HTTPHeader methods. * Implement and partially test URLEncodedFormParameterEncoder. * Remove unnecessary TODOs. * Correct spelling in the file name. * Update errors, documentation, and tests. * Allow customization of space encoding and percent escaped character set. * Enabled code coverage for iOS, macOS, and tvOS framework schemes (#2645) * Updates for review. * Whitespace cleanup. * Whitespace cleanup. * Update comments, DRY up single value container. * Add additional tests. * Squashed commit of the following: commit 7a73af6 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:39:20 2018 -0500 Async RequestAdapter (#2628) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. commit ccfb96a Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:32:04 2018 -0500 Alamofire 5: Server Trust Errors (#2608) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Refactor evaluation API, DRY up a little bit. * Update convienience property. * Add comment for public `Error` API. * Add add methods to HTTPHeaders, whitespace cleanup. * Call add instead of update. * Add additional tests. * Add more tests, remove dead code. * More tests for failing optional encodes. * Customizable Empty Response Handling (#2639) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. * Add HTTPHeaders type. * Update for review suggestions. * Add HTTPHeaders tests, cleanup whitespace. * Add inline documentation. * Prototype encodable request support. * Formalize ParamterEncoder protocol and initial API. * Whitespace cleanup. * Add URLEncodedFormEncoder. * Sort HTTPHeader methods. * Implement and partially test URLEncodedFormParameterEncoder. * Remove unnecessary TODOs. * Correct spelling in the file name. * Update errors, documentation, and tests. * Support customizable empty reponse codes and methods. * Allow customization of space encoding and percent escaped character set. * Allow customization of space encoding and percent escaped character set. * Alamofire 5: Empty Response Refactor (2nd Refactor) (#2646) * Removed AnyResponseSerializer since it is no longer in use * Moved empty request and response status code logic into protocol extension * Squashed commit of the following: commit a3dc191 Author: Jon Shier <[email protected]> Date: Sat Nov 24 17:35:17 2018 -0500 Add additional tests. commit ae8fde4 Merge: 34f3668 ea48749 Author: Jon Shier <[email protected]> Date: Sat Nov 24 16:43:12 2018 -0500 Merge remote-tracking branch 'origin/feature/httpheaders' into feature/encodable-requests # Conflicts: # Source/AFError.swift commit ea48749 Author: Jon Shier <[email protected]> Date: Sat Nov 24 16:25:48 2018 -0500 Call add instead of update. commit 2d73562 Author: Jon Shier <[email protected]> Date: Sat Nov 24 16:24:48 2018 -0500 Add add methods to HTTPHeaders, whitespace cleanup. commit f2bf395 Merge: 410a2e3 7a73af6 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:45:38 2018 -0500 Merge remote-tracking branch 'origin/alamofire5' into feature/httpheaders # Conflicts: # Tests/SessionManagerTests.swift commit 410a2e3 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:44:15 2018 -0500 Squashed commit of the following: commit 7a73af6 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:39:20 2018 -0500 Async RequestAdapter (#2628) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. commit ccfb96a Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:32:04 2018 -0500 Alamofire 5: Server Trust Errors (#2608) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Refactor evaluation API, DRY up a little bit. * Update convienience property. * Add comment for public `Error` API. commit 7a73af6 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:39:20 2018 -0500 Async RequestAdapter (#2628) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Make RequestAdapter async. commit ccfb96a Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:32:04 2018 -0500 Alamofire 5: Server Trust Errors (#2608) * Work towards server trust enhancements. * Refactor the rewrite! (#2585) * Refactor request storage out of SessionDelegate. * Continue development. * Rename SessionManager -> Session, update environment. * Rename global Alamofire enum to AF, to avoid collision. * Sort project. * Whitespace cleanup. * Reimplement module changes from bad rebase. * Finalize errors, refactor testing. * Standardize self-signed support, add error descriptions. * Remove per-target setting. * Refactor evaluation API, DRY up a little bit. * Update convienience property. * Add comment for public `Error` API. commit 34f3668 Author: Jon Shier <[email protected]> Date: Wed Nov 21 19:26:32 2018 -0500 Add additional tests. commit ba2e15c Author: Jon Shier <[email protected]> Date: Wed Nov 21 18:56:14 2018 -0500 Update comments, DRY up single value container. commit 38d764b Author: Jon Shier <[email protected]> Date: Wed Nov 21 18:36:01 2018 -0500 Whitespace cleanup. commit b0cf0c5 Merge: 22ccd91 4adae8c Author: Jon Shier <[email protected]> Date: Wed Nov 21 18:35:16 2018 -0500 Merge remote-tracking branch 'origin/feature/httpheaders' into feature/encodable-requests commit 4adae8c Author: Jon Shier <[email protected]> Date: Wed Nov 21 18:30:59 2018 -0500 Whitespace cleanup. commit aaa3e6a Author: Jon Shier <[email protected]> Date: Wed Nov 21 18:29:30 2018 -0500 Updates for review. commit 22ccd91 Author: Christian Noon <[email protected]> Date: Wed Nov 21 14:20:08 2018 -0800 Enabled code coverage for iOS, macOS, and tvOS framework schemes (#2645) * Update tests and clean up default value handling. * Fix bad merge. * Fix misspelling. * Refactor Notifications (#2654) * Refactor notifications. * Add Foundation import for SPM. * Alamofire 5: Project Cleanup and Unification (#2655) * Whitespace cleanup. * Reupdate Example app. * Update project to Xcode 10 format, move settings into base if possible. * Adopt recommended project settings. * Attempt to make tests more reliable. * Another attempt at test reliability. * Another attempt at test stabalization. * Remove debug build to speed up testing. * Ensure Swift 4.2 for local pod builds. * Fix #2658: default empty response values non-public (#2659) * Alamofire 5: Abstract decoders for decodable response serialization (#2657) * Cleanup previous changes. * Add DataDecoder, refactor DecodableResponseSerializer. * Add top level doc comment for DataDecoder. * Remove unnecessary access modifier. * Prepare for Alamofire 5.0.0.beta.1 (#2660) * Start CHANGELOG. * Finalize README. * Update Jazzy docs. * Update README. * Update for review. * Fix test availability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
I want to be able to mock
NetworkReachabilityManagerfor unit testing in integrating projects. The current protection level ofpublicdoes not allow inheritance forcing me to inconvenient testing methods with wrappers and the like. By changing the protection level toopenthe class and the appropriate members can be subclassed and overridden making mocking it is a breeze.Implementation Details 🚧
I've changed protection levels from
publictoopenwhere applicable.Testing Details 🔍
I used a test project to reproduce the problem with inheritance and subsequent overriding. I made my changes and ran the test suite to make sure everything passes. I was thinking of creating a mock of
NetworkReachabilityManagerand adding it to the test target of the example app but I'm not sure it's a viable means of testing since compilation would be the assertion and the mock would be unused. Let me know if you think any kind of test is appropriate for this PR.