Introduce SQL dialects #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to ignore start of comments when inside a literal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 97.57% 98.53% +0.96%
==========================================
Files 44 47 +3
Lines 2309 3830 +1521
Branches 261 323 +62
==========================================
+ Hits 2253 3774 +1521
Misses 56 56 ☔ View full report in Codecov by Sentry. |
We just want to know where the content starts and ends As postgres has tagged literals
If we have a single character, the start and end should be the same, these represent the indices.
Revisiting another approach that doesn't require parsing
|
We took a different approach, avoiding complicated parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to understand escaping correctly per database dialect.