Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky performance test #481

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix flaky performance test #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3dc47
Fix flaky performance test
timokoessler Dec 18, 2024
097769d
Increase to 25%
timokoessler Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/helpers/ip-matcher/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,6 @@ t.test("test performance in comparison to node:net.blocklist", async (t) => {

const percentageDiff = ((blockListMs - ipMatcherMs) / ipMatcherMs) * 100;

// Expect the IPMatcher to be at least 100% faster than the BlockList
t.same(percentageDiff > 100, true);
// Expect the IPMatcher to be faster than the BlockList
t.same(percentageDiff > 25, true);
});
Loading