Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Prisma ORM #460

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Support Prisma ORM #460

wants to merge 21 commits into from

Conversation

timokoessler
Copy link
Contributor

@timokoessler timokoessler commented Nov 22, 2024 •
edited
Loading

Adds support for the ORM https://www.npmjs.com/package/prisma, because it's using rust db drivers.

Note: MongoDB is supported by Prisma only in replication mode, that's why a new container is added

@timokoessler timokoessler changed the base branch from main to beta November 22, 2024 12:03
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.74924% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
library/sinks/Prisma.ts 91.49% 21 Missing ⚠️
...lities/sql-injection/dialects/SQLDialectGeneric.ts 71.42% 2 Missing ⚠️
...brary/agent/hooks/onInspectionInterceptorResult.ts 98.24% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@timokoessler timokoessler changed the title Support Prisma ORM (WIP) Support Prisma ORM Nov 25, 2024
@timokoessler timokoessler marked this pull request as ready for review November 25, 2024 13:01
hansott
hansott reviewed Nov 25, 2024
View reviewed changes
library/agent/hooks/wrapExport.ts Outdated
result: InterceptorResult,
pkgInfo: WrapPackageInfo,
start: number
) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split because of length?

hansott
hansott reviewed Nov 25, 2024
View reviewed changes
end2end/tests/hono-prisma.test.js Outdated Show resolved Hide resolved
end2end/tests/hono-prisma.test.js Outdated Show resolved Hide resolved
end2end/tests/hono-prisma.test.js Outdated Show resolved Hide resolved
end2end/tests/hono-prisma.test.js Outdated Show resolved Hide resolved
Base automatically changed from beta to main December 3, 2024 15:57
An error occurred while trying to automatically change base from beta to main December 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansott hansott hansott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timokoessler @hansott