Move config.json to config.ts and add some comments #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "!", | ||
| ";", | ||
| "\\+", // This checks for "+" | ||
| "\\-", // This checks for "-" |
There was a problem hiding this comment.
deze dubbele escape klopt nietm eer dan right?
|
|
||
| // We make use of double backslashes to create a single backslash in the RegEx | ||
| const SQL_DANGEROUS_IN_STRING = [ | ||
| "\\\\", // Check for backslashes : "\" |
There was a problem hiding this comment.
deze dubbele escape klopt nietm eer dan right?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 94.25% 94.62% +0.36%
==========================================
Files 20 22 +2
Lines 1585 1694 +109
Branches 195 195
==========================================
+ Hits 1494 1603 +109
Misses 91 91 ☔ View full report in Codecov by Sentry. |
hansott
reviewed
Feb 27, 2024
library/src/vulnerabilities/sql-injection/detectSQLInjection.ts
Outdated
Show resolved
Hide resolved
…ts-for-regex-escape * 'main' of github.com:AikidoSec/node-RASP: Move to separate file Remove typedoc Split regex up into different smaller regex strings Add comments to regex Remove some comments
It's easier to reason about this when the escaping happens just before using in a regex. This also allows us to use the config data for any purpose. Not just regexes. How beautiful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.